Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the nodes info API #4055

Closed
clintongormley opened this issue Nov 2, 2013 · 2 comments · Fixed by #4336
Closed

Changes to the nodes info API #4055

clintongormley opened this issue Nov 2, 2013 · 2 comments · Fixed by #4336
Assignees
@spinscale
Labels
>breaking v1.0.0.RC1

Comments

@clintongormley
Copy link

Recommendations:

Remove the all and clear flags. Default to return all by default, unless specific metrics specified.

Change the path format to:

/_nodes/{nodes}/{metric}

where:

  • {nodes}: comma-delimited list of nodes or blank
  • {metric} is blank or comma-delimited list of metrics

Metrics can be any of:

  • http
  • jvm
  • network
  • os
  • plugin
  • process
  • settings
  • thread_pool
  • timeout
  • transport

NOTE: Node names and metric names could clash, if you name your nodes eg process. Should probably accept _all in the {nodes} parameter.
@ghost ghost assigned spinscale Dec 3, 2013
@spinscale spinscale mentioned this issue Dec 4, 2013
Merged
@spinscale
Copy link
Contributor

After reading #4057 - why not simply make the URL /_nodes/{nodes}/infos/{metric} and allow nodes and metric to be blank. Removes also the possible clash you mentioned in the last sentence...

@clintongormley
Copy link
Author

I'd be up for supporting /_nodes/{nodes}/info/{metric} (note info with the s), but i would make it optional, so that GET /_nodes would return the same thing as GET /_nodes/info

karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 11, 2014
@karmi
[API] Changed the endpoint for "Nodes Info" API from `/_cluster/nodes…
baaaba8 
…` to `/_nodes`

The "_cluster" prefix has been removed in Elasticsearch 1.0.

The "/_nodes" endpoint is supported since ~ version 0.19,
so this doesn't break backwards compatibility.

Related:

* elastic/elasticsearch#4055
* elastic/elasticsearch#4065
* elastic/elasticsearch#4347
* elastic/elasticsearch#4608
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
@spinscale @brusic
Simplify usage of nodes info API
7fe8bce 
Important: This breaks backwards compatibility with 0.90

* Removed endpoints: /_cluster/nodes, /_cluster/nodes/nodeId1,nodeId2
* Disallow usage of parameters, but make required metrics part of URI
* Changed NodesInfoRequest to return everything by default
* Fixed NPE in NodesInfoResponse

Closes elastic#4055
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 23, 2014
@karmi
[API] [1.0] Changed the namespace for cluster.nodes_* APIs to nodes
8f3b806 
Due to changes in Elasticsearch 1.0 API, the client "namespaces" have been
changed to reflect the change in URLs: `_cluster/nodes` => `_nodes`

Thus, instead of:

    client.cluster.nodes_info

the new API is:

    client.nodes.info

Related:

* elastic/elasticsearch#4055
* elastic/elasticsearch#4336
* elastic/elasticsearch#4769
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 24, 2014
@karmi
[API] [1.0] Changed the namespace for cluster.nodes_* APIs to nodes
efedca5 
Due to changes in Elasticsearch 1.0 API, the client "namespaces" have been
changed to reflect the change in URLs: `_cluster/nodes` => `_nodes`

Thus, instead of:

    client.cluster.nodes_info

the new API is:

    client.nodes.info

Related:

* elastic/elasticsearch#4055
* elastic/elasticsearch#4336
* elastic/elasticsearch#4769
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 24, 2014
@karmi
[API] [1.0] Changed the namespace for cluster.nodes_* APIs to nodes
64f93ca 
Due to changes in Elasticsearch 1.0 API, the client "namespaces" have been
changed to reflect the change in URLs: `_cluster/nodes` => `_nodes`

Thus, instead of:

    client.cluster.nodes_info

the new API is:

    client.nodes.info

Related:

* elastic/elasticsearch#4055
* elastic/elasticsearch#4336
* elastic/elasticsearch#4769
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 28, 2014
@karmi
[API] [1.0] Changed the namespace for cluster.nodes_* APIs to nodes
acb7053 
Due to changes in Elasticsearch 1.0 API, the client "namespaces" have been
changed to reflect the change in URLs: `_cluster/nodes` => `_nodes`

Thus, instead of:

    client.cluster.nodes_info

the new API is:

    client.nodes.info

Related:

* elastic/elasticsearch#4055
* elastic/elasticsearch#4336
* elastic/elasticsearch#4769
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 29, 2014
@karmi
[API] [1.0] Changed the namespace for cluster.nodes_* APIs to nodes
560647b 
Due to changes in Elasticsearch 1.0 API, the client "namespaces" have been
changed to reflect the change in URLs: `_cluster/nodes` => `_nodes`

Thus, instead of:

    client.cluster.nodes_info

the new API is:

    client.nodes.info

Related:

* elastic/elasticsearch#4055
* elastic/elasticsearch#4336
* elastic/elasticsearch#4769
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 29, 2014
@karmi
[API] [1.0] Changed the namespace for cluster.nodes_* APIs to nodes
8af6059 
Due to changes in Elasticsearch 1.0 API, the client "namespaces" have been
changed to reflect the change in URLs: `_cluster/nodes` => `_nodes`

Thus, instead of:

    client.cluster.nodes_info

the new API is:

    client.nodes.info

Related:

* elastic/elasticsearch#4055
* elastic/elasticsearch#4336
* elastic/elasticsearch#4769
javanna added a commit that referenced this issue Feb 6, 2014
@javanna
Updated nodes info endpoint in elasticsearch.yml
80ab15d 
Relates to #4055
javanna added a commit that referenced this issue Feb 6, 2014
@javanna
Updated nodes info endpoint in elasticsearch.yml
fc5a9eb 
Relates to #4055
javanna added a commit that referenced this issue Feb 6, 2014
@javanna
Updated nodes info endpoint in elasticsearch.yml
0f4c9e3 
Relates to #4055
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@javanna
Updated nodes info endpoint in elasticsearch.yml
e818855 
Relates to elastic#4055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spinscale spinscale

Labels
>breaking v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify usage of nodes info API spinscale/elasticsearch
2 participants
@clintongormley @spinscale